Skip to content

Handle "width" in tables in direct_html #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2019

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Dec 6, 2019

Docbook handles [width=50%] on tables by adding the width to the
<table> tag. So we should too, just to be even.

Docbook handles `[width=50%]` on tables by adding the width to the
`<table>` tag. So we should too, just to be even.
@nik9000 nik9000 requested review from JoshMock and olksdr December 6, 2019 19:29
Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and easy. 👏

@nik9000 nik9000 merged commit 59ca39b into elastic:master Dec 6, 2019
@nik9000
Copy link
Member Author

nik9000 commented Dec 6, 2019

There a zillion more table things to come one day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants